core: Cleanup blockpool with annotation #14895
Conversation
This is similar to rook#14052 we did for radosnamespace and this is an extension to support cleanup at the blockpool level to cleanup the images and the snapshots in a pool. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1
force-pushed
the
cleanup-block
branch
from
8ea6ed2 to
4e29717
Compare
Tested it, it works as expected |
@travisn i assume this is not required because we always use subvolumegroup and subvolume concept and we already have cleanup job for subvolumegroup |
Yeah, that's probably sufficient. Though perhaps for consistency it could help on the CephFilesystem so that all subvolumegroups would be automatically cleaned up, instead of annotating each svg individually. |
core: Cleanup blockpool with annotation (backport #14895)
Yeah we could try that, let me see if i can take care of it. |
This is similar to #14052 we did for radosnamespace and this is an extension to support cleanup at the blockpool level to cleanup the images and the snapshots in a pool.
Motive:- I saw an issue where users are using scripts to cleanup the resources, I thought it's better to have the functionality in Rook itself.
Checklist:
Note:- I tried to keep the changes minimal as much as possible and reuse whatever we have for the rados namespace cleanup (with little modification)
If this is good, i would like to do one final round of testing before merging.