mds: fix liveness probe timeout #14798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
added
ceph-mds
BlaineEXE
commented
Oct 3, 2024
Comment on lines
-78
to
-79
| "timeout", | ||
| fmt.Sprintf("%d", mdsCmdTimeout), |
There was a problem hiding this comment.
timeout can keep the script from running too long, but it exits with error code after timeout, which we don't want. To resolve, move the config for the timeout from here, to the new --connect-timeout=<mdsCmdTimeout> in the script.
|
Converting to draft while I test what Travis suggested in huddle |
BlaineEXE
force-pushed
the
mds-liveness-probe-fix-timeout
branch
2 times, most recently
from
bd1feca to
27207af
Compare
When the MDS liveness probe times out, it should not fail the probe. If the cluster has a network partition or other issue that causes the Ceph mon cluster to become unstable, `ceph ...` commands can hang and cause a timeout. In this case, the MDS should not be restarted so as to not cause cascading cluster disruption. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
BlaineEXE
force-pushed
the
mds-liveness-probe-fix-timeout
branch
from
27207af to
ad1bae9
Compare
|
Tested well manually in 2 different environments 👍 |
subhamkrai
approved these changes
Oct 7, 2024
This was referenced Oct 7, 2024
mergify bot
added a commit
that referenced
this pull request
Oct 7, 2024
mds: fix liveness probe timeout (backport #14798)
mergify bot
added a commit
that referenced
this pull request
Oct 7, 2024
mds: fix liveness probe timeout (backport #14798)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the MDS liveness probe times out, it should not fail the probe. If the cluster has a network partition or other issue that causes the Ceph mon cluster to become unstable,
ceph ...commands can hang and cause a timeout. In this case, the MDS should not be restarted so as to not cause cascading cluster disruption.Checklist: