build: support golang 1.23 #14748
Merged
build: support golang 1.23 #14748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Thanks for adding this, we are past due to add the support since it was released last month. Could you also add the new version to the go-version matrix in the build CI workflow as seen here for previous versions when there are multiple golang versions supported? Thanks!
obnoxxx
force-pushed
the
support-go-1-23
branch
from
b49c19e to
7a8454a
Compare
subhamkrai
approved these changes
Sep 23, 2024
parth-gr
reviewed
Sep 23, 2024
.github/workflows/build.yml
Outdated
| @@ -71,7 +71,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| go-version: ["1.22"] | |||
| go-version: ["1.22", "1.23] | |||
There was a problem hiding this comment.
should we change the other CI??
There was a problem hiding this comment.
I was not sure. We could do it as follow-up.
BlaineEXE
requested changes
Sep 23, 2024
.github/workflows/build.yml
Outdated
| @@ -71,7 +71,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| go-version: ["1.22"] | |||
| go-version: ["1.22", "1.23] | |||
There was a problem hiding this comment.
Suggested change
| go-version: ["1.22", "1.23] | |
| go-version: ["1.22", "1.23"] |
Signed-off-by: Michael Adam <obnox@samba.org>
obnoxxx
force-pushed
the
support-go-1-23
branch
from
7a8454a to
9ecd6a2
Compare
parth-gr
approved these changes
Sep 23, 2024
travisn
approved these changes
Sep 23, 2024
BlaineEXE
approved these changes
Sep 23, 2024
6 tasks
travisn
added a commit
that referenced
this pull request
Sep 25, 2024
build: support golang 1.23 (backport #14748)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, only golang version 1.22 is supported for building rook.
This change adds support for golang version 1.23
Checklist: