core: fix Ceph monitor deployment in separate zones #14636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Rook would fail to create monitors for a `CephCluster` spec that
required them to be located in distinct failure domains:
```yaml
spec:
mon:
count: 3
failureDomainLabel: topology.kubernetes.io/zone
zones:
- eu-central-1a
- eu-central-1b
- eu-central-1c
```
This was due to the fact that Rook was mistakenly getting the
`failureDomainLabel` from `spec.mon.stretchCluster.failureDomainLabel`.
This commit ensures `spec.mon.failureDomainLabel` is being used instead, which
fixes the cluster deployment for the spec above.
Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
BenoitKnecht
force-pushed
the
fix-ceph-mon-failuredomainlabel
branch
from
626a4e1 to
1c45677
Compare
BenoitKnecht
changed the title
travisn
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
The fix looks good, thanks for submitting, I see this was introduced with #12384.
Note that there is another way to have the mons spread across zones as well, by specifying the node affinity, antiaffinity, etc, in the placement.mon
This was referenced Aug 23, 2024
Thanks for merging, and thanks for the suggestion, it's actually a much better way to achieve what I was trying to do. 🙂 |
mergify bot
added a commit
that referenced
this pull request
Aug 27, 2024
core: fix Ceph monitor deployment in separate zones (backport #14636)
mergify bot
added a commit
that referenced
this pull request
Aug 27, 2024
core: fix Ceph monitor deployment in separate zones (backport #14636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Rook would fail to create monitors for a
CephClusterspec that required them to be located in distinct failure domains:This was due to the fact that Rook was mistakenly getting the
failureDomainLabelfromspec.mon.stretchCluster.failureDomainLabel.This commit ensures
spec.mon.failureDomainLabelis being used instead, which fixes the cluster deployment for the spec above.Checklist: