-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: PendingReleaseNotes for update netNamespaceFilePath PR #13809
doc: PendingReleaseNotes for update netNamespaceFilePath PR #13809
Conversation
3672b4e
to
b8a0ccd
Compare
PendingReleaseNotes.md
Outdated
@@ -5,6 +5,7 @@ | |||
- The removal of `CSI_ENABLE_READ_AFFINITY` option and its replacement with per-cluster | |||
read affinity setting in cephCluster CR (CSIDriverOptions section) in [PR](https://github.com/rook/rook/pull/13665) | |||
- Allow setting the Ceph `application` on a pool | |||
- updating `netNamespaceFilePath` for all clusterIDs in rook-ceph-csi-config configMap [PR](https://github.com/rook/rook/pull/13613) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also describe the impact of the breaking change? Users need to find how to know if they are impacted, and what is the impact for them. Is there any action they need to take if they are impacted?
Signed-off-by: Praveen M <m.praveen@ibm.com>
b8a0ccd
to
10dea45
Compare
- updating `netNamespaceFilePath` for all clusterIDs in rook-ceph-csi-config configMap in [PR](https://github.com/rook/rook/pull/13613) | ||
- Issue: The netNamespaceFilePath isn't updated in the CSI config map for all the clusterIDs when `CSI_ENABLE_HOST_NETWORK` is set to false in `operator.yaml` | ||
- Impact: This results in the unintended network configurations, with pods using the host networking instead of pod networking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need help understanding this pending release note. This is listed as a breaking change, but there are no instructions for users to follow to keep their cluster from breaking. Is this actually a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think nothing was required from the user point and we never supported moving from multus/pod network to host networking or vice-versa, @iPraveenParihar can you please check this and confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlaineEXE actually this was an issue that I believed users should be aware of if they were using Pod networking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think nothing was required from the user point and we never supported moving from multus/pod network to host networking or vice-versa
I thought there was a period of time where we had CSI_ENABLE_HOST_NETWORK: false
as the default value for all Rook users? Am I misremembering?
If that was the default, then we need to have supported users setting that value back to true
so they could get in line with the latest recommendations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was enabled briefly three years ago (see #8085), but I'm not sure we need to worry about that too much since it was for such a short time and users would have had serious issues if they didn't already convert back to host networking.
doc: PendingReleaseNotes for update netNamespaceFilePath PR (#13613)
Checklist: