Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if saving the Cargo cache can speed up FreeBSD #5756

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The FreeBSD build is very slow as it is running a non-native image. In this PR, I see if we can use the same caching technique we use for the other builds to save and restore the Cargo cache.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 9:07am

Copy link

github-actions bot commented Dec 6, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#cache-bsd-cargo

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-780gyy75j-rollup-js.vercel.app/repl/?pr=5756

Copy link

github-actions bot commented Dec 6, 2024

Performance report

  • BUILD: 8166ms, 730 MB
    • initialize: 0ms, 26.5 MB
    • generate module graph: 3136ms, 552 MB
      • generate ast: 1500ms, 545 MB
    • sort and bind modules: 435ms, 595 MB
    • mark included statements: 4588ms, 730 MB
      • treeshaking pass 1: 1542ms, 694 MB
      • treeshaking pass 2: 746ms, 720 MB
      • treeshaking pass 3: 295ms, 721 MB
      • treeshaking pass 4: 273ms, 723 MB
      • treeshaking pass 5: 318ms, 727 MB
      • treeshaking pass 6: 264ms, 730 MB
      • treeshaking pass 7: 242ms, 731 MB
      • treeshaking pass 8: 234ms, 734 MB
      • treeshaking pass 9: 214ms, 730 MB
      • treeshaking pass 10: 217ms, 730 MB
      • treeshaking pass 11: 214ms, 730 MB
  • GENERATE: 882ms, 978 MB
    • initialize render: 0ms, 870 MB
    • generate chunks: 85ms, 875 MB
      • optimize chunks: 0ms, 873 MB
    • render chunks: 774ms, 955 MB
    • transform chunks: 18ms, 978 MB
    • generate bundle: 0ms, 978 MB

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (d3464e4) to head (1692a01).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5756   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         258      258           
  Lines        8072     8072           
  Branches     1361     1361           
=======================================
  Hits         7992     7992           
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit c3283cf into master Dec 6, 2024
42 checks passed
@lukastaegert lukastaegert deleted the cache-bsd-cargo branch December 6, 2024 10:17
Copy link

github-actions bot commented Dec 6, 2024

This PR has been released as part of rollup@4.28.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant