Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supports modify the import attributes key in the config file #5743

Merged
merged 8 commits into from
Nov 30, 2024

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Nov 27, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #5299 (reply in thread)

Description

Introduce the configImportAttributesKey option to control the finalized keyword of import attributes in the config file.
BTW, updated the max Node version from 20 to 22 for github action.

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 8:48am

Copy link

github-actions bot commented Nov 27, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/config-import-attributes-key

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-44d092beq-rollup-js.vercel.app/repl/?pr=5743

Copy link

github-actions bot commented Nov 27, 2024

Performance report

  • BUILD: 8128ms, 727 MB
    • initialize: 0ms, 26.6 MB
    • generate module graph: 3114ms, 553 MB
      • generate ast: 1496ms, 546 MB
    • sort and bind modules: 446ms, 592 MB
    • mark included statements: 4571ms, 727 MB
      • treeshaking pass 1: 1537ms, 694 MB
      • treeshaking pass 2: 740ms, 723 MB
      • treeshaking pass 3: 295ms, 724 MB
      • treeshaking pass 4: 272ms, 723 MB
      • treeshaking pass 5: 316ms, 726 MB
      • treeshaking pass 6: 261ms, 733 MB
      • treeshaking pass 7: 243ms, 731 MB
      • treeshaking pass 8: 236ms, 736 MB
      • treeshaking pass 9: 217ms, 733 MB
      • treeshaking pass 10: 220ms, 731 MB
      • treeshaking pass 11: 216ms, 727 MB
  • GENERATE: 890ms, 978 MB
    • initialize render: 0ms, 870 MB
    • generate chunks: 86ms, 876 MB
      • optimize chunks: 0ms, 873 MB
    • render chunks: 780ms, 957 MB
    • transform chunks: 19ms, 978 MB
    • generate bundle: 0ms, 978 MB

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (a0f1dcc) to head (099cb2a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5743   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         258      258           
  Lines        8070     8072    +2     
  Branches     1360     1361    +1     
=======================================
+ Hits         7990     7992    +2     
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a nice solution but the best thing to do apart from a breaking change I guess

@lukastaegert lukastaegert added this pull request to the merge queue Nov 30, 2024
@lukastaegert lukastaegert removed this pull request from the merge queue due to a manual request Nov 30, 2024
@TrickyPi
Copy link
Member Author

It seems that there is a compatibility issue between higher versions of Node and nyc, and I haven’t found the exact problem yet. So, I temporarily used version 22.0.0.

@lukastaegert lukastaegert added this pull request to the merge queue Nov 30, 2024
@TrickyPi
Copy link
Member Author

TrickyPi commented Nov 30, 2024

I found the minimum incompatible Node.js version: 22.7.0. The issue was caused by PR (nodejs/node#53619), though I feel this might ultimately need to be resolved within the nyc package. As a temporary workaround, enable option --no-experimental-detect-module to avoid the problem.

Merged via the queue into master with commit 5053019 Nov 30, 2024
40 checks passed
@lukastaegert lukastaegert deleted the fix/config-import-attributes-key branch November 30, 2024 09:04
Copy link

This PR has been released as part of rollup@4.28.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants