-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: supports modify the import attributes key in the config file #5743
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix/config-import-attributes-key Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report
|
4cadf45
to
cdc97f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5743 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 258 258
Lines 8070 8072 +2
Branches 1360 1361 +1
=======================================
+ Hits 7990 7992 +2
Misses 53 53
Partials 27 27 ☔ View full report in Codecov by Sentry. |
1d86f47
to
1d75ffc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a nice solution but the best thing to do apart from a breaking change I guess
It seems that there is a compatibility issue between higher versions of Node and nyc, and I haven’t found the exact problem yet. So, I temporarily used version 22.0.0. |
0765c2e
to
099cb2a
Compare
I found the minimum incompatible Node.js version: 22.7.0. The issue was caused by PR (nodejs/node#53619), though I feel this might ultimately need to be resolved within the nyc package. As a temporary workaround, enable option |
This PR has been released as part of rollup@4.28.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5299 (reply in thread)
Description
Introduce the
configImportAttributesKey
option to control the finalized keyword of import attributes in the config file.BTW, updated the max Node version from 20 to 22 for github action.