Fix panic with unicode characters #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sapphi-red
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5674 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 242 242
Lines 9352 9352
Branches 2473 2473
=======================================
Hits 9263 9263
Misses 58 58
Partials 31 31 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Sep 27, 2024
|
This PR has been released as part of rollup@4.22.5. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This PR reverts updates of unicode related rust packages.
It seems after updating them, swc panics at this line with
width 3 given for non-narrow character.https://github.com/swc-project/swc/blob/14cfd70ee00938497ce6b59f68332f9daa17378b/crates/swc_common/src/syntax_pos.rs#L702