feat: restrict typings and refactor RenderedModule
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hyf0
force-pushed
the
03-09-feat_restrict_typings_and_refactor_RenderedModule_
branch
from
c73b9f8 to
50dc2b3
Compare
✅ Deploy Preview for rolldown-rs canceled.
|
✅ Deploy Preview for rolldown-rs canceled.
|
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
deleted the
03-09-feat_restrict_typings_and_refactor_RenderedModule_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types in
@rolldown/nodeis kind of over-complex and mix up with rollup's types. I think we need make types reliable to our users and use other ways to keep the compatibility with rollup's types.Types should make user aware what features are available and what aren't.
https://github.com/rolldown-rs/rolldown/blob/f81f87dc4a67f18b8de26f3084d20e003aec3d68/crates/rolldown_common/src/types/rendered_module.rs#L4-L5
Above length is calculated based on utf-8 while rollup emits length based utf-16. Remove these currently, until we find a way to get correct result.
Test Plan