Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build import analysis plugin #2051

Merged
merged 14 commits into from
Aug 24, 2024
Merged

feat: build import analysis plugin #2051

merged 14 commits into from
Aug 24, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

Description

@netlify Netlify
Copy link

netlify bot commented Aug 24, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 173d743
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66c9cfdead014000088ac7f1

IWANABETHATGUY
IWANABETHATGUY commented Aug 24, 2024
View reviewed changes
crates/rolldown/src/utils/ecma_visitors/mod.rs
fn visit_import_expression(&mut self, it: &mut oxc::ast::ast::ImportExpression<'a>) {
self.ensure_uniqueness(it.span_mut());
walk_mut::walk_import_expression(self, it);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr will insert import('dep') it may lead conflict if you have multiple await () that needs to transform.

IWANABETHATGUY
IWANABETHATGUY commented Aug 24, 2024
View reviewed changes
crates/rolldown_plugin/src/plugin_driver/build_hooks.rs
plugin.call_transform_ast(ctx, HookTransformAstArgs { cwd: args.cwd, ast: args.ast })?;
args.ast = plugin.call_transform_ast(
ctx,
HookTransformAstArgs { cwd: args.cwd, ast: args.ast, id: args.id },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used to filter out module in node_modules, https://github.com/rolldown/vite/blob/8eed5766df862049aae43a7f1611acb83363b89a/packages/vite/src/node/plugins/importAnalysisBuild.ts#L217-L219

@IWANABETHATGUY IWANABETHATGUY changed the title Feat/build import analysis feat: build import analysis plugin Aug 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     54.9±1.21ms        ? ?/sec    1.02     55.8±1.22ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     77.2±1.02ms        ? ?/sec    1.03     79.6±2.03ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     95.0±1.98ms        ? ?/sec    1.02     96.7±1.67ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     62.4±0.77ms        ? ?/sec    1.03     64.3±1.17ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    103.2±1.32ms        ? ?/sec    1.00    102.4±1.14ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.03    197.9±6.07ms        ? ?/sec    1.00    192.2±4.99ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    238.0±2.81ms        ? ?/sec    1.02    241.6±5.17ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    117.9±0.94ms        ? ?/sec    1.01    118.9±2.54ms        ? ?/sec
bundle/bundle@threejs                                               1.03     38.6±3.24ms        ? ?/sec    1.00     37.3±0.37ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     87.5±5.62ms        ? ?/sec    1.00     86.3±1.54ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.02    105.0±2.40ms        ? ?/sec    1.00    103.3±2.01ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.1±1.11ms        ? ?/sec    1.00     47.3±0.81ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    391.2±3.45ms        ? ?/sec    1.01    394.0±3.26ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    983.0±6.87ms        ? ?/sec    1.01    993.6±7.81ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1242.1±6.57ms        ? ?/sec    1.00   1242.4±8.82ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    460.2±4.33ms        ? ?/sec    1.01    463.6±4.86ms        ? ?/sec
remapping/remapping                                                 1.00     31.7±0.34ms        ? ?/sec    1.05     33.3±0.37ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     82.4±0.27ms        ? ?/sec    1.01     83.6±0.27ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.4±0.74ms        ? ?/sec    1.00     82.5±1.56ms        ? ?/sec
scan/scan@threejs                                                   1.00     29.0±0.26ms        ? ?/sec    1.01     29.4±1.25ms        ? ?/sec
scan/scan@threejs10x                                                1.00    289.8±5.67ms        ? ?/sec    1.00    290.2±2.95ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 24, 2024 15:05
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 24, 2024
Merged via the queue into main with commit 9e461c2 Aug 24, 2024
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/build-import-analysis branch August 24, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @hyf0