Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused ts file #2019

Merged
merged 3 commits into from
Aug 19, 2024
Merged

chore: remove unused ts file #2019

merged 3 commits into from
Aug 19, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

Description

@netlify Netlify
Copy link

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 0a0512b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66c33e3e61384800082378d5

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 19, 2024 10:20
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
@IWANABETHATGUY
chore: remove unused ts file (#2019)
bfcf7a7 
<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
hyf0
hyf0 reviewed Aug 19, 2024
View reviewed changes
packages/rolldown/src/utils/plugin/index.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep this one? I'm gonna use it in composingJsPlugins.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hyf0 hyf0 removed this pull request from the merge queue due to a manual request Aug 19, 2024
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 348e04f Aug 19, 2024
20 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the chore/remove-unused-file branch August 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 left review comments

@underfin underfin underfin approved these changes

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IWANABETHATGUY @underfin @hyf0