Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime_module): use rolldown:runtime as the resource id of runtime module instead of \0<runtime> #1331

Merged
merged 1 commit into from
Jun 3, 2024
Merged

refactor(runtime_module): use rolldown:runtime as the resource id of runtime module instead of \0<runtime> #1331

merged 1 commit into from
Jun 3, 2024

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 3, 2024

Description

This was referenced Jun 3, 2024
Merged
Merged
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jun 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 mentioned this pull request Jun 3, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(ace105c)
  • pr: 06-04-refactor_runtime_module_use_rolldown_runtime_as_the_resource_id_of_runtime_module_instead_of_0_runtime_(6e09d53)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     30.3±0.81ms        ? ?/sec    1.02     31.0±0.46ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     21.1±0.68ms        ? ?/sec    1.03     21.8±0.87ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     40.9±0.58ms        ? ?/sec    1.00     40.7±0.66ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.01    335.2±3.34ms        ? ?/sec    1.00    332.7±4.56ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.01    210.2±2.22ms        ? ?/sec    1.00    208.4±2.17ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00   447.3±10.81ms        ? ?/sec    1.00    448.7±7.42ms        ? ?/sec

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 3, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1331 will not alter performance

Comparing 06-04-refactor_runtime_module_use_rolldown_runtime_as_the_resource_id_of_runtime_module_instead_of_0_runtime_ (6e09d53) with main (ace105c)

Summary

✅ 6 untouched benchmarks

@hyf0 hyf0 force-pushed the 06-04-refactor_runtime_module_use_rolldown_runtime_as_the_resource_id_of_runtime_module_instead_of_0_runtime_ branch from d4eae7d to 9ae7d55 Compare June 3, 2024 18:04
@hyf0 hyf0 mentioned this pull request Jun 3, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.78%. Comparing base (85650b3) to head (9ae7d55).
Report is 3 commits behind head on main.

❗ Current head 9ae7d55 differs from pull request most recent head 6e09d53

Please upload reports for the commit 6e09d53 to get more accurate results.

Files Patch % Lines
crates/rolldown/src/utils/render_normal_module.rs 92.30% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   86.76%   86.78%   +0.01%     
==========================================
  Files         137      137              
  Lines        7051     7038      -13     
==========================================
- Hits         6118     6108      -10     
+ Misses        933      930       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyf0 hyf0 mentioned this pull request Jun 3, 2024
Merged
@hyf0 hyf0 force-pushed the 06-04-feat_output_make_output_folding-friendly_using_region_ branch from 8277e90 to e21f7cc Compare June 3, 2024 18:23
@hyf0 hyf0 force-pushed the 06-04-refactor_runtime_module_use_rolldown_runtime_as_the_resource_id_of_runtime_module_instead_of_0_runtime_ branch from 9ae7d55 to 5e216a2 Compare June 3, 2024 18:23
@hyf0 hyf0 force-pushed the 06-04-feat_output_make_output_folding-friendly_using_region_ branch from e21f7cc to 09ac115 Compare June 3, 2024 18:23
@hyf0 hyf0 force-pushed the 06-04-refactor_runtime_module_use_rolldown_runtime_as_the_resource_id_of_runtime_module_instead_of_0_runtime_ branch from 5e216a2 to a458a53 Compare June 3, 2024 18:24
Base automatically changed from 06-04-feat_output_make_output_folding-friendly_using_region_ to main June 3, 2024 18:24
@hyf0 hyf0 force-pushed the 06-04-refactor_runtime_module_use_rolldown_runtime_as_the_resource_id_of_runtime_module_instead_of_0_runtime_ branch from a458a53 to 6e09d53 Compare June 3, 2024 18:24
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6e09d53
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/665e0a5f7d983900081ea091

@hyf0 hyf0 merged commit 886a5f4 into main Jun 3, 2024
10 checks passed
@hyf0 hyf0 deleted the 06-04-refactor_runtime_module_use_rolldown_runtime_as_the_resource_id_of_runtime_module_instead_of_0_runtime_ branch June 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hyf0