feat(plugin/replace): prevent assignment #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rolldown-rs canceled.
|
ikkz
force-pushed
the
feat/replace-prevent-assignment
branch
from
49cac21 to
f5b4ba1
Compare
ikkz
force-pushed
the
feat/replace-prevent-assignment
branch
from
f5b4ba1 to
dd13452
Compare
Looks like both regex and fancy_regex have issues on porting regex of js. I'm considering taking https://github.com/ridiculousfish/regress or https://github.com/hyf0/ecma_regex/issues more seriously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #2057
This pr implements the same function with rollup's preventAssignment: https://github.com/rollup/plugins/blob/master/packages/replace/src/index.js#L77-L82
And part of the logic is put into the match loop, because of
fancy-regex's limitation that variable size of expression cannot be used in lookbehind (fancy-regex/fancy-regex#74 and fancy-regex/fancy-regex#109)