Add Haiku support #340

ghost · 2020-08-14T20:47:05Z

Haiku OS has a compatible POSIX layer. So it's possible to add support for it. Basic features are tested working on Haiku.

rofl0r

overall looks good, but left some comments

src/libproxychains.c

rofl0r · 2020-08-15T00:31:27Z

src/common.c

@@ -74,7 +74,11 @@ char *get_config_path(char* default_path, char* pbuf, size_t bufsize) {

 	// priority 3; $HOME/.proxychains/proxychains.conf
 	path = getenv("HOME");
+#ifdef IS_HAIKU
+	snprintf(pbuf, bufsize, "%s/config/settings/%s", path, PROXYCHAINS_CONF_FILE);


i'd rather just add this path unconditionally as "priority 4" rather than having distrinct layout per OS

ghost · 2020-08-15T05:58:38Z

Thanks for your response. To do a pull request one must visit https://review.haiku-os.org and submit a change there for review. You don't have to create an account there, cause when you try to sign in you will be prompted to allow Gerrit access your github account. Once linked, go to the dashboard->YOUR->CHANGES->CREATE CHANGE and follow the instructions.
I am glad to help you to forward this patch to haiku coummunity. If you insist me to help you post the patch, I will do it tonight. Your account name may be mentioned and referenced as this patch is made by you :)

rofl0r · 2020-08-15T11:46:53Z

Once linked, go to the dashboard->YOUR->CHANGES->CREATE CHANGE and follow the instructions.

i already tried that, but then pushing failed because "committer's email address not registered" and you can't just put your email addr in gerrit, you need to "unlock" it with a confirmation mail. since i use a noreply email address for commits, that impossible. you see, a lot of hassle.

@waddlesplash ^

ghost · 2020-08-15T12:52:36Z

If changes could be made on Haiku's side, I think there is no need to merge my commit here. Probably the only thing that needs to be updated is in the README: list haiku as a supported platform

Once linked, go to the dashboard->YOUR->CHANGES->CREATE CHANGE and follow the instructions.

i already tried that, but then pushing failed because "committer's email address not registered" and you can't just put your email addr in gerrit, you need to "unlock" it with a confirmation mail. since i use a noreply email address for commits, that impossible. you see, a lot of hassle.

@waddlesplash ^

No worries. Then I will help you to submit the changes :)

rofl0r · 2020-08-15T13:26:34Z

If changes could be made on Haiku's side, I think there is no need to merge my commit here.

we'd still need the configure part for LIBDL (in case haiku doesn't provide an empty libdl.a if the dl functionality is in libc.so), the user directory plus the undef satosin (it's a namespace violation of haiku to make it available like this, but otoh FreeBSD also defines it, although only with some feature test macro)

I will help you to submit the changes

thanks, much appreciated

ghost · 2020-08-15T13:36:23Z

If changes could be made on Haiku's side, I think there is no need to merge my commit here.

we'd still need the configure part for LIBDL (in case haiku doesn't provide an empty libdl.a if the dl functionality is in libc.so), the user directory plus the undef satosin (it's a namespace violation of haiku to make it available like this, but otoh FreeBSD also defines it, although only with some feature test macro)

I will help you to submit the changes

thanks, much appreciated

You're welcome. Yep, I will fix my commit later :)

…d a new configure file path for haiku

ghost · 2020-08-15T14:21:27Z

hey @rofl0r,

Review progress of your patch is available here: https://review.haiku-os.org/c/haiku/+/3147
New changes were made, please check :)

rofl0r · 2020-08-15T14:55:38Z

thanks, your PR looks perfect now

New changes were made, please check :)

i think the /* XXX */ item can be safely removed, as the prototype is now correct and void* can be cast to any pointer type.

edit: your change of int type to int af seems bogus. maybe it would be best to just remove the variable names from the declaration

ghost · 2020-08-15T15:16:54Z

i think the /* XXX / item can be safely removed, as the prototype is now correct and void can be cast to any pointer type.

I know..that's why I added /*type*/.. this is copied from the implementation. I will remove it if it's necessary!

rofl0r · 2020-08-15T15:18:26Z

let's leave this open until haiku merges the fix, then i'll merge

rofl0r · 2020-08-17T08:30:31Z

haiku is fixed: haiku/haiku@7de1ebe

thanks!

Begasus

Had a look at an open PR at haikuports at: haikuports/haikuports#5212
Made some changes as that one isn't ready for use, but starting proxychains4 crashes (build with gcc8):

~> proxychains4-x86 curl suip.biz/ip/
[proxychains] config file found: /packages/proxychains_ng_x86-4.14~git-1/.settings/proxychains.conf
[proxychains] preloading /packages/proxychains_ng_x86-4.14~git-1/.self/lib/x86/libproxychains4.so
[proxychains] DLL init: proxychains-ng 4.14-git
resolve symbol "___tls_get_addr" returned: -2147478780
[proxychains] Strict chain  ...  127.0.0.1:9050  ...  timeout
curl: (7) Couldn't connect to server
Kill Thread

Begasus · 2020-09-13T17:05:33Z

configure

@@ -213,6 +218,9 @@ elif isbsd ; then
 elif issolaris; then
 	echo "CFLAGS+=-DIS_SOLARIS -D__EXTENSIONS__" >> config.mak
 	echo "SOCKET_LIBS=-lsocket -lnsl" >> config.mak
+elif ishaiku ; then
+	echo LIBDL=>>config.mak
+	echo "CFLAGS+=-DIS_HAIKU" >> config.mak


Maybe add this?

+ echo "SOCKET_LIBS=-lnetwork" >> config.mak

maybe? does it fix it or not ?

maybe? does it fix it or not ?

Doesn't fix, but on Haiku 32bit with gcc2 we use -lsocket, for gcc8 we have to use -lnetwork, so if this is a requirement I think it should be included?

why does the choice of gcc affect in which library stuff is being put? that sounds illogical.
which functions that we require/hook reside in libsocket/libnetwork?

Not sure (not a developer here, and don't know the ins and outs for the Haiku core), but could be that -lsocket is kept for backwards compatibility for BeOS apps/libraries

PS, thought that the lines preceding this would give a clue that it could be needed?

echo "SOCKET_LIBS=-lsocket -lnsl" >> config.mak

Begasus · 2020-09-13T17:06:37Z

src/common.c

+
+    // priority 3b: ~/config/settings/proxychains.conf (for haiku)
+	path = getenv("HOME");
+	snprintf(pbuf, bufsize, "%s/config/settings/%s", path, PROXYCHAINS_CONF_FILE);
+	path = pbuf;
+	if(check_path(path))
+		goto have;


Is this needed? proxychains.conf is saved in /boot/system/settings for this (running "runConfigure ./configure"

rofl0r · 2020-09-13T19:24:15Z

resolve symbol "___tls_get_addr" returned: -2147478780

where's that coming from ?

Kill Thread

and this?

[proxychains] Strict chain ... 127.0.0.1:9050 ... timeout

if this is tor, did you configure it as socks4 proxy as it should be ?

Begasus · 2020-09-13T19:36:38Z

resolve symbol "___tls_get_addr" returned: -2147478780

where's that coming from ?

Kill Thread

and this?

[proxychains] Strict chain ... 127.0.0.1:9050 ... timeout

if this is tor, did you configure it as socks4 proxy as it should be ?

I only used an example on how to use the binary, not so familiar with these, is there any documentation to do a quick check otherwise?

rofl0r · 2020-09-13T19:58:15Z

is there any documentation to do a quick check otherwise

you need a working proxy, then add the correct proxy url to the end of proxychains.conf

for example if you run tor, the example config should work.

if you don't wanna install tor you can try microsocks which is a tiny socks5 proxy server i wrote.

if you have issues, we can chat if you come to the IRC channel mentioned in README.

Added HaikuOS support

e706ca0

rofl0r requested changes Aug 15, 2020

View reviewed changes

ugly workarounds are reverted; forced macro satosin(x) undef'ed; adde…

5c8de78

…d a new configure file path for haiku

rofl0r approved these changes Aug 15, 2020

View reviewed changes

ghost closed this Aug 15, 2020

rofl0r reopened this Aug 15, 2020

rofl0r merged commit 0ee5db6 into rofl0r:master Aug 17, 2020

Begasus reviewed Sep 13, 2020

View reviewed changes

Begasus mentioned this pull request Sep 13, 2020

proxychains_ng: new recipe haikuports/haikuports#5212

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Haiku support #340

Add Haiku support #340

ghost commented Aug 14, 2020

rofl0r left a comment

rofl0r Aug 15, 2020

ghost commented Aug 15, 2020

rofl0r commented Aug 15, 2020

ghost commented Aug 15, 2020

rofl0r commented Aug 15, 2020

ghost commented Aug 15, 2020

ghost commented Aug 15, 2020

rofl0r commented Aug 15, 2020 •

edited

Loading

ghost commented Aug 15, 2020 •

edited by rofl0r

Loading

rofl0r commented Aug 15, 2020

rofl0r commented Aug 17, 2020

Begasus left a comment •

edited

Loading

Begasus Sep 13, 2020

rofl0r Sep 13, 2020

Begasus Sep 13, 2020

rofl0r Sep 13, 2020

Begasus Sep 13, 2020

Begasus Sep 13, 2020

Begasus Sep 13, 2020

rofl0r commented Sep 13, 2020

Begasus commented Sep 13, 2020

rofl0r commented Sep 13, 2020

Add Haiku support #340

Add Haiku support #340

Conversation

ghost commented Aug 14, 2020

rofl0r left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Aug 15, 2020

rofl0r commented Aug 15, 2020

ghost commented Aug 15, 2020

rofl0r commented Aug 15, 2020

ghost commented Aug 15, 2020

ghost commented Aug 15, 2020

rofl0r commented Aug 15, 2020 • edited Loading

ghost commented Aug 15, 2020 • edited by rofl0r Loading

rofl0r commented Aug 15, 2020

rofl0r commented Aug 17, 2020

Begasus left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rofl0r commented Sep 13, 2020

Begasus commented Sep 13, 2020

rofl0r commented Sep 13, 2020

rofl0r commented Aug 15, 2020 •

edited

Loading

ghost commented Aug 15, 2020 •

edited by rofl0r

Loading

Begasus left a comment •

edited

Loading