Added sequential all examples generation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we know we need to generate all the possible examples rather than picking up each example randomly, we can iterate over all possible combinations sequentially. Another related optimization is that now we calculate max possible combinations (cardinality) of each entity in the very beginning, before generating examples.
|
Hi Yuri, this looks great thank you! |
|
Hi Rodrigo, thank you! |
|
published v2.3.2, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we know we need to generate all the possible examples rather than picking up each example randomly, we can iterate over all possible combinations sequentially.
Another related optimization is that now we calculate max possible combinations (cardinality) of each entity in the very beginning, before generating examples.
Minor change: displaying circular entities references path and nested slots path.