Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gemstones: Containers: Podman: Quatlet #2103

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Gemstones: Containers: Podman: Quatlet #2103

merged 3 commits into from
Jun 9, 2024

Conversation

ChrSteinert
Copy link
Contributor

@ChrSteinert ChrSteinert commented Jun 8, 2024 •
edited by sspencerwire
Loading

As a result of #2093, this adds documentation mentioning Quadlets.

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

This is my first time adding something to the Rocky Linux documentation – so I am happy with any feedback and suggestions, and am willing to extend this further, if wanted.
For now, I think it is nicely sized for a gem, and it points to further documentation, if that is of interest to the reader.

@sspencerwire
Copy link
Contributor

sspencerwire commented Jun 8, 2024 •
edited
Loading

Hello @ChrSteinert and welcome to the project! Thanks for contributing here. I've placed some comments inline, but when you modify another document, it's important to add your name to the meta at the top of the file as a contributor (in this case):

---
title: Podman
author: Neel Chauhan
contributors: Steven Spencer, Ganna Zhyrnova
date: 2024-03-07
tags:
  - docker
  - podman
---

Actually, I don't believe there's any need for inline comments, so if you correct this one issue and perhaps the one misspelling of systemctl here:

sysmteclt --user daemon-reload

I'll go ahead and merge it. Thank you!!

@ChrSteinert
Copy link
Contributor Author

Great! I added myself to the contributors and fixed the misspelling.

Thank you, for your guidance!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Test results for 55cbc52:

Number of broken URLs: 1

 
URL,RESULT,FILENAME
 https://azuremarketplace.microsoft.com/en-us/marketplace/apps/resf.rockylinux-aarch64,failed,guides/cloud/migration-to-new-azure-images.md

@sspencerwire
Copy link
Contributor

Perfect! Thank you @ChrSteinert

@sspencerwire sspencerwire merged commit c5d3e16 into rocky-linux:main Jun 9, 2024
3 checks passed
cyqsimon
cyqsimon reviewed Jun 10, 2024
View reviewed changes
Copy link

@cyqsimon cyqsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late. Excellent work but I did spot two typos.

Also, this article needs updating as well. Are you interested in doing it? If so, cool; if not, I'm happy to work on a PR.

docs/gemstones/containers/podman.md
To run the generator and let systemd know that there is a new service run:

```bash
sysmtemclt --user daemon-reload
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

systemctl*

docs/gemstones/containers/podman.md
Podman additionally provides the `generate systemd` subcommand. It can be used to generate `systemd` service files.

> [!IMPORTANT]
> `generate systemd` is now deprecated and will not receive further features. Usage of Quadlet is recommendet.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommended*

@ChrSteinert
Copy link
Contributor Author

ChrSteinert commented Jun 10, 2024 via email •
edited
Loading

@ChrSteinert
Copy link
Contributor Author

And oh now -- I just saw that I broke the formatting.

grafik

I will fix this too.

@ChrSteinert ChrSteinert mentioned this pull request Jun 10, 2024
Closed
@sspencerwire
Copy link
Contributor

@all-contributors add @ChrSteinert for content

@allcontributors allcontributors bot mentioned this pull request Jun 10, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@sspencerwire

I've put up a pull request to add @ChrSteinert! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyqsimon cyqsimon

@sspencerwire sspencerwire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrSteinert @sspencerwire @cyqsimon