Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1867 fix markdown violation in guides #1995

Merged
merged 1 commit into from
Apr 5, 2024
Merged

#1867 fix markdown violation in guides #1995

merged 1 commit into from
Apr 5, 2024

Conversation

nishaaaaaant
Copy link
Contributor

@nishaaaaaant nishaaaaaant commented Apr 4, 2024 •
edited by sspencerwire
Loading

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Test results for 54ec20a:

Number of broken URLs: 5

 
URL,RESULT,FILENAME
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md
 https://hbjy.dev/,failed,guides/contribute/README.md
 http://untroubled.org/bcron/,failed,guides/automation/cronie.md
 https://www.ssi.gouv.fr/en/,failed,books/disa_stig/disa_stig_part2.md
 https://cisecurity.org,failed,books/disa_stig/disa_stig_part2.md

sspencerwire
sspencerwire reviewed Apr 5, 2024
View reviewed changes
docs/guides/mirror_management/add_mirror_manager.md
- "Private" - Checking this box hides your mirror from public use.
- "User active" - Uncheck this box to temporarily disable this site, it will be removed from public listings.
- "All sites can pull from me?" - Enable all mirror sites to pull from me without explicitly adding them to my list.
- "Comments for downstream siteadmins. Please include your synchronization source here to avoid dependency loops."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishaaaaaant I believe @alemorvan has mentioned this before, but bullet items are NOT in error when prefixed with an *. A bullet can be either a * or -. Mixing those in the same bullet sequence is a markdown no-no, but either is acceptable as far as Markdown is concerned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I understood his point and agree with it. Moving forward I'll definitely take care of this point. @sspencerwire

@sspencerwire sspencerwire merged commit 9cc97dd into rocky-linux:main Apr 5, 2024
3 checks passed
@nishaaaaaant nishaaaaaant deleted the fix-mardown-violation branch April 7, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspencerwire sspencerwire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishaaaaaant @sspencerwire