fix(model): relations are not being applied if any is null #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoPedroAS51
force-pushed
the
fix/relationships
branch
from
2529d46 to
a65f91b
Compare
Peter-Krebs
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
Thanks for the quick fix @JoaoPedroAS51
During testing I saw code coverage took a little dip for utils.js. We could get better code coverage if tests explored every if/else branch. Otherwise I see no problems. That's a separate issue for me.
|
Thank you guys @JoaoPedroAS51 and @Peter-Krebs for help! @JoaoPedroAS51 when you had a feee time could you present to @Peter-Krebs the new GitHub Actions/NPM automations? Oh, and new docs as well. Thanks! Edit: I have invite you @Peter-Krebs as collaborator in the past. If you missed let me know. |
|
@Peter-Krebs I already made the tests for utilities but I forgot to push lol Edit: Actually, I will make some more improvements before push the tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133