This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
app/sandbox: Allow to define annotations for sandbox from CLI #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhlfr
force-pushed
the
nhlfr/sandbox-annotations-cli
branch
from
c00e255 to
d4a8c68
Compare
iaguis
suggested changes
Sep 29, 2017
rkt/app_sandbox.go
Outdated
| func parseAnnotations(flagUserAnnotations *kvMap) types.UserAnnotations { | ||
| if flagUserAnnotations.IsEmpty() { | ||
| func parseUserAnnotations(flagUserAnnotations *kvMap) types.UserAnnotations { | ||
| if flagAnnotations.IsEmpty() { |
There was a problem hiding this comment.
This should be flagUserAnnotations
Before this change, "app sandbox" CLI allowed only to define user annotations. User annotations were designed mostly to store annotations from Kubernetes API. At the same time, we want to store some data related to rktlet which aren't k8s annotations (i.e. log mode). Defining annotations is allowed here by --annotation CLI option (i.e. --annotation=foo=bar). Ref rkt#3813
nhlfr
force-pushed
the
nhlfr/sandbox-annotations-cli
branch
from
d4a8c68 to
68cd245
Compare
Merged
This was referenced Oct 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, "app sandbox" CLI allowed only to define
user annotations. User annotations were designed mostly to
store annotations from Kubernetes API. At the same time, we
want to store some data related to rktlet which aren't k8s
annotations (i.e. log mode).
Defining annotations is allowed here by --annotation CLI
option (i.e. --annotation=foo=bar).
Ref #3813