-
Notifications
You must be signed in to change notification settings - Fork 883
Conversation
Documentation/devel/architecture.md
Outdated
There are also out of tree stage1: | ||
- [stage1-xen](https://github.com/rkt/stage1-xen), stage1 based on the Xen hypervisor | ||
- [volo](https://github.com/lucab/rkt-volo), stage1 written in Rust, akin to stage1-fly | ||
- [docker-skim](https://github.com/coreos/docker-skim), TODO: not clear to me what it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference: this is a weaker version of stage1-fly, which gets rid of the chroot by bundling only some dependencies and then letting run
inject LD_PRELOAD
and other PATH-related tricks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I updated the text.
This was discussed on: rkt#3645 (comment) /cc @lucab @euank @sstabellini @n0rad @iaguis @schu
There are also out of tree stage1: | ||
- [stage1-xen](https://github.com/rkt/stage1-xen), stage1 based on the Xen hypervisor | ||
- [volo](https://github.com/lucab/rkt-volo), stage1 written in Rust, akin to stage1-fly | ||
- [docker-skim](https://github.com/coreos/docker-skim), a weaker version of stage1-fly using `LD_PRELOAD` tricks instead of chroot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be in favour of not including this one. I think it should remain largely unused, replaced entirely by torcx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep it here if we want, this is developer docs and having links around comes handy when you are just looking for source references.
Thanks for the PR! It looks good from my point of view. I wonder if it is also worth having a little paragraph outside "Documentation/devel" to point users, rather than developers, to out-of-tree stage1s. Something like Documentation/integrations.md, but that's obviously for projects that integrate rkt. This would be for optional features maintained externally. I don't know if there are any other components that could be listed there as "things that work with rkt". |
I agree with Stefano. This IMHO ok to merge as is, but devdocs isn't meant for user consumption. We can probably add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
On Mon, 26 Jun 2017, Luca Bruno wrote:
I agree with Stefano. This IMHO ok to merge as is, but devdocs isn't meant for user consumption. We can probably add a running-stage1-xen.md like we have for fly
and kvm, and then link them all from a short paragraph in README.
That would be ideal!
|
This was discussed on:
#3645 (comment)
/cc @lucab @euank @sstabellini @n0rad @iaguis @schu
Not sure it is the correct place to list the stage1s. Should it be a new file on the same model as https://github.com/rkt/rkt/blob/master/Documentation/production-users.md?