Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agg): support aggregate: prefixed scalar function in streaming agg #18205

Merged
merged 2 commits into from
Aug 27, 2024
Merged

feat(agg): support aggregate: prefixed scalar function in streaming agg #18205

merged 2 commits into from
Aug 27, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 22, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After several previous PRs:

we can now easily support using aggregate: prefixed scalar function (including UDF) as streaming aggregate function. This resolves #16767.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

  • Support AGGREGATE: prefixed scalar function in streaming aggregation

This was referenced Aug 22, 2024
Merged
Merged
Merged
Merged
@stdrc Graphite App
Copy link
Member Author

stdrc commented Aug 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title handle AggKind::WrapScalar in streaming agg feat: support aggregate: prefixed scalar function in streaming agg Aug 22, 2024
@stdrc stdrc changed the title feat: support aggregate: prefixed scalar function in streaming agg feat(agg): support aggregate: prefixed scalar function in streaming agg Aug 22, 2024
@stdrc stdrc marked this pull request as ready for review August 22, 2024 18:23
@stdrc stdrc requested review from fuyufjh, xxchan and st1page August 22, 2024 18:24
@stdrc stdrc added the user-facing-changes Contains changes that are visible to users label Aug 22, 2024
@stdrc stdrc force-pushed the rc/aggregate-prefixed-udf-in-streaming-agg branch from cd79732 to c5fddb4 Compare August 23, 2024 06:25
Base automatically changed from rc/fix-udf-aggregate-prefix to main August 23, 2024 07:19
stdrc added 2 commits August 23, 2024 15:26
@stdrc
handle AggKind::WrapScalar in streaming agg
024a7bb 
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc
add e2e test for wrap_scalar agg
d2ada0d 
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc force-pushed the rc/aggregate-prefixed-udf-in-streaming-agg branch from c5fddb4 to d2ada0d Compare August 23, 2024 07:27
fuyufjh
fuyufjh approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stdrc stdrc added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit e3a9d37 Aug 27, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/aggregate-prefixed-udf-in-streaming-agg branch August 27, 2024 04:33
kwannoel pushed a commit that referenced this pull request Aug 27, 2024
@stdrc @kwannoel
feat(agg): support aggregate: prefixed scalar function in streaming…
a9ced67 
… agg (#18205)

Signed-off-by: Richard Chien <stdrc@outlook.com>
@BugenZhao BugenZhao mentioned this pull request Dec 11, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@xxchan xxchan Awaiting requested review from xxchan

@st1page st1page Awaiting requested review from st1page

Assignees
No one assigned
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: A simple approach towards Stateless UDAF
2 participants
@stdrc @fuyufjh