Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github codespace devcontainer configuration #680

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 6, 2022

This PR adds support for setting up the dev environment for Risinglight with Github Codespace. https://docs.github.com/en/codespaces

@skyzh
Copy link
Member

skyzh commented Aug 9, 2022

Thanks for this PR! But I doubt whether this is necessary. Do you mainly develop RisingLight on GitHub Codespace?

@yeya24
Copy link
Contributor Author

yeya24 commented Aug 9, 2022

This comes in handy sometimes to start a dev environment for Rust and Risinglight to read/write the code. But it is not as good as the local environment due to the resource limitation, which makes it takes a long time to compile the code.

I think it is a good compliment because it gives you an out-of-box environment with the required deps. For beginners like me this is already very useful to try the project.

@skyzh
Copy link
Member

skyzh commented Aug 9, 2022

That's cool.

  • I don't think it's good to use zsh here. We should keep the environment as simple as possible.
  • Should install the Rust version of rust-toolchain file in RisingLight repo, instead of just specifying nightly toolchain.

@yeya24
Copy link
Contributor Author

yeya24 commented Aug 13, 2022

Thanks. I have updated the PR, please take a look.

Ben Ye added 3 commits August 12, 2022 20:54
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@yeya24 yeya24 force-pushed the support-codespace branch from 421cbca to 33c4311 Compare August 13, 2022 03:54
@skyzh skyzh merged commit 93ce6ec into risinglightdb:main Aug 18, 2022
@yeya24 yeya24 deleted the support-codespace branch August 18, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants