Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SquirrelPanel): text shown in top-left corner #856

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix(SquirrelPanel): text shown in top-left corner #856

merged 1 commit into from
Mar 15, 2024

Conversation

lotem
Copy link
Member

@lotem lotem commented Mar 15, 2024

it happens when the panel is displayed for the first time. usually it's the ascii mode status tooltip.

calling setTextContainerInset: in drawRect: has no effect for what's being drawn. fixed by setting the inset on an ealier occasion.

@lotem lotem requested a review from LEOYoon-Tsaw March 15, 2024 14:40
it happens when the panel is displayed for the first time.
usually it's the ascii mode status tooltip.

calling setTextContainerInset: in drawRect: has no effect for what's
being drawn. fixed by setting the inset on an ealier occasion.
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksqsf ksqsf merged commit 277ebfa into master Mar 15, 2024
2 checks passed
@lotem lotem deleted the fix branch March 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants