Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X/Y graphs for selected tracepoints #180

Closed
eero-t opened this issue Apr 27, 2018 · 3 comments
Closed

X/Y graphs for selected tracepoints #180

eero-t opened this issue Apr 27, 2018 · 3 comments

Comments

@eero-t
Copy link

eero-t commented Apr 27, 2018

Currently there seems to be only a log of the tracepoints selected by "Select tracepoints" view in gputop-ui.

It would be nice to be able to add a timeline for each of the selected tracepoints, to see for how many times each of them occurs during the sampling period, and if it happens only once, when exactly that happens (e.g. flip).

For some of the tracepoints like this one:
kworker/u16:1-21675 [000] .... 17170.769758: intel_gpu_freq_change: new_freq=400

Showing the indicated value instead would be nice. In above case, one could then compare kernel GPU frequency requests against the actual "AVG GPU Core Frequency" OA counter value.

@djdeath
Copy link
Collaborator

djdeath commented May 6, 2018

Actually if you look at the timeline window, there a another timeline belong (you might need to grow the window in height).
If you're using this branch : https://github.com/djdeath/linux/tree/wip/djdeath/oa-next
GPUTop will be able to merge to 2 timelines into one.
Unfortunately this isn't upstream yet, the patches need a bit more work.

@djdeath djdeath closed this as completed May 6, 2018
@eero-t
Copy link
Author

eero-t commented May 8, 2018

Timeline where each individual trace point event is shown as a horizontal line (similar to other tracing GUIs), is useful when one is investigating latency issues (i.e. very short time intervals), but I was thinking more about X/Y timelines like the "Global" & "Per context" ones.

One where Y-value is either:

  • The value given by the event (e.g. frequency requested from GPU by kernel), or
  • Number of events during the selected period

For latter, I would use the visible OA sampling period as that would help #188.

@eero-t eero-t changed the title Graphs for selected tracepoints X/Y graphs for selected tracepoints May 8, 2018
@eero-t eero-t changed the title X/Y graphs for selected tracepoints graphs for selected tracepoints May 8, 2018
@eero-t eero-t changed the title graphs for selected tracepoints X/Y graphs for selected tracepoints May 8, 2018
@eero-t
Copy link
Author

eero-t commented May 9, 2018

Maybe these would actually be better to be handled as special "tracepoint counters", along the lines of what I described in #188?

Currently I have only 2 tracepoints I care to track this way, user space buffer swaps, and kernel GPU freq request. I already have ticket for the first, I can add another one for the second one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants