fix: various bugs/missing features #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pad via delegatecall
Feature/safe owner cleanup
Feature/safe owner launchpad
zeroknots
reviewed
Jul 1, 2024
| @@ -25,8 +32,16 @@ import { MODULE_TYPE_VALIDATOR } from "erc7579/interfaces/IERC7579Module.sol"; | |||
| * technique](https://github.com/safe-global/safe-modules/pull/184) | |||
| * @author rhinestone | zeroknots.eth | |||
| */ | |||
| contract Safe7579Launchpad is IAccount, SafeStorage { | |||
| event ModuleInstalled(uint256 moduleTypeId, address module); | |||
There was a problem hiding this comment.
This is now in IERC7579AccountEvents
zeroknots
reviewed
Jul 1, 2024
| @@ -110,6 +125,28 @@ contract Safe7579Launchpad is IAccount, SafeStorage { | |||
| }); | |||
| } | |||
|
|
|||
| function addSafe7579( | |||
There was a problem hiding this comment.
additional function that allows existing safe accounts to get safe7579 with a single transaction
zeroknots
reviewed
Jul 1, 2024
| // because the `EncodedSafeOpStruct` struct has no "dynamic" fields so its memory layout | ||
| // is identical to the | ||
| // result of `abi.encode`-ing the individual fields. | ||
| EncodedSafeOpStruct memory encodedSafeOp = EncodedSafeOpStruct({ |
There was a problem hiding this comment.
this is fixing discussed struct change:
#3
zeroknots
reviewed
Jul 1, 2024
| } from "@ERC4337/account-abstraction/contracts/core/UserOperationLib.sol"; | ||
| import { SAFE_OP_TYPEHASH, ISafeOp } from "../interfaces/ISafeOp.sol"; | ||
|
|
||
| abstract contract SafeOp is ISafeOp { |
There was a problem hiding this comment.
moved this logic to an abstract contract as this functionality has to be utilized by both Safe7579 and Launchpad
zeroknots
approved these changes
Jul 1, 2024
kopy-kat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things: