remediations #4
Merged
remediations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foo wip
zeroknots
commented
Jun 17, 2024
There was a problem hiding this comment.
Note: H1
I think adding this access control should make remediate the frontrunning / race condition problem entirely.
I still think having a launchpad like single transaction install process for existing safe accounts is a good idea, but delegatecall to multisend should be sufficient for that?!
zeroknots
force-pushed
the
feature/remediation
branch
from
6767458 to
bab5361
Compare
zeroknots
commented
Jun 18, 2024
| // ISafe7579(initData.safe7579).launchpadValidators(initData.validators); | ||
| // but we need to append msg.sender (entrypoint) to ERC2771 style access control, to protect | ||
| // the launchpadValidator function | ||
| (bool success,) = address(initData.safe7579).call( |
There was a problem hiding this comment.
adding ERC2771 style appending of msg.sender to calldata. this should offer sufficient frontrun protection for the launchpadValidators function
zeroknots
commented
Jun 18, 2024
| function launchpadValidators(ModuleInit[] calldata validators) | ||
| external | ||
| override | ||
| onlyEntryPointOrSelf |
There was a problem hiding this comment.
added access control here
adding test case to remove multi type module
…pad via delegatecall
Feature/safe owner cleanup
Feature/safe owner launchpad
Fix: final remediations
fix: various bugs/missing features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing remediations for Ackee's Safe7579 security audit, as well as other security improvements.