fix: poc for bricked account #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroknots
reviewed
Oct 10, 2024
| // @dev No events emitted here. Launchpad is expected to do this. | ||
| // at this point, the safeproxy singleton is not yet updated to the SafeSingleton | ||
| // calling execTransactionFromModule is not available yet. | ||
| if (!$validators.alreadyInitialized({ account: msg.sender })) { |
There was a problem hiding this comment.
think this is a quite elegant solution tbh.
There was a problem hiding this comment.
TODO: we should write some docs for this if we go with this solution
zeroknots
reviewed
Oct 10, 2024
| userOp.simulateUserOp(address(entrypoint)); | ||
| entrypoint.handleOps(userOps, payable(address(0x69))); | ||
|
|
||
| assertTrue(true); |
There was a problem hiding this comment.
we should add a testcase here that verifies that the safe is operational
zeroknots
reviewed
Oct 15, 2024
| * account during the execution phase of the first UserOperation in order to comply with ERC-4337. | ||
| * This means that if the exection of the first UserOperation fails, the account could be | ||
| * permanently bricked. To avoid this, make sure that all the initialization and call data are | ||
| * correctly set up and do not cause a revert on any chain that the account should be deployed on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.