feat: prepare release #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
small
|
Reviewpad Report ℹ️ Messages
|
zolamk
reviewed
Feb 24, 2023
plugins/aladino/actions/review.go
Outdated
| latestReviewEvent, err := mapReviewStateToEvent(latestReview.State) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // If the latest review is the same as the one we want to create, and the last push date is before the latest review | ||
| // then we skip the review creation. | ||
| if latestReview.State == reviewEvent && latestReview.Body == reviewBody && lastPushDate.Before(*latestReview.SubmittedAt) { |
There was a problem hiding this comment.
This condition will never be true because we are not comparing the mapped state to the event right
Suggested change
| if latestReview.State == reviewEvent && latestReview.Body == reviewBody && lastPushDate.Before(*latestReview.SubmittedAt) { | |
| if latestReviewEvent == reviewEvent && latestReview.Body == reviewBody && lastPushDate.Before(*latestReview.SubmittedAt) { |
There was a problem hiding this comment.
I'm using latestReviewEvent which is a result from mapReviewStateToEvent(latestReview.State). Isn't this what you're saying?
There was a problem hiding this comment.
I already pushed a fix for this review 😅 , just wanted to leave the reason for the change here, it should be like that right
reviewpad
bot
added
the
requires-author-attention
reviewpad
bot
removed
the
requires-author-attention
📈 Pull Request Metrics💻 Coding Time: 1 minute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a series of fixes for the release.
Related issue
none
Type of change
Improvements (non-breaking change without functionality)
How was this tested?
Checklist
task check -fand have no issuesCode review and merge strategy (ship/show/ask)