Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: process event payload #605

Merged
merged 4 commits into from
Jan 11, 2023
Merged

refactor: process event payload #605

merged 4 commits into from
Jan 11, 2023

Conversation

zolamk
Copy link
Contributor

@zolamk zolamk commented Jan 4, 2023

Description

refactors EventData into EventDetails

  • rename EventData to EventDetails
  • add event payload to EventDetails
  • refactor ProcessEvent to return a struct instead of array

Related issue

Closes #560

Type of change

Improvements (non-breaking change without functionality)

How was this tested?

Unit tests

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have ran task check -f and have no issues

Code review and merge strategy (ship/show/ask)

  • Ask: this pull request requires a code review before merge

@reviewpad reviewpad bot added large large pull request ask Pull request requires a code review before merge run-build Label that controls when build should be executed critical Modifications to critical changes labels Jan 4, 2023
@reviewpad
Copy link

reviewpad bot commented Jan 4, 2023 •
edited
Loading

Reviewpad Report

⚠️ Warnings

  • The pull request does not have a linear history

ℹ️ Messages

  • @marcelosousa: you are being notified because critical code was modified

@reviewpad reviewpad bot added the waiting-review PR waiting for review label Jan 11, 2023
@ferreiratiago ferreiratiago force-pushed the refactor-process-event-payload branch from c7b9f39 to a93337f Compare January 11, 2023 17:58
@ferreiratiago ferreiratiago merged commit a24eedb into main Jan 11, 2023
@ferreiratiago ferreiratiago deleted the refactor-process-event-payload branch January 11, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferreiratiago ferreiratiago ferreiratiago approved these changes

@marcelosousa marcelosousa Awaiting requested review from marcelosousa

Assignees

@zolamk zolamk

Labels
ask Pull request requires a code review before merge critical Modifications to critical changes large large pull request run-build Label that controls when build should be executed waiting-review PR waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process event payload
2 participants
@zolamk @ferreiratiago