-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-pr-review: Support multiline comments #680
Conversation
haya14busa
commented
Jul 22, 2020
- Updated Unreleased section in CHANGELOG or it's not notable changes.
--- Range | ||
a = 1 | ||
b = 2 | ||
c = 3 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 1
|
||
line 5 | ||
|
||
--- Range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 2 (same line)
line 5 | ||
|
||
--- Range | ||
a = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 3 (with line-break)
a = 1 | ||
b = 2 | ||
c = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)
--- Range | ||
a = 1 | ||
b = 2 | ||
c = 3 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 1
a = 1 | ||
b = 2 | ||
c = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)
line 5 | ||
|
||
--- Range | ||
a = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 3 (with line-break)
a = 1 | ||
b = 2 | ||
c = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)
line 5 | ||
|
||
--- Range | ||
a = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 3 (with line-break)
a = 1 | ||
b = 2 | ||
c = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)
# ------------------------ >8 ------------------------ # reviewdog results
# ------------------------ >8 ------------------------ # reviewdog results
# ------------------------ >8 ------------------------ # reviewdog results
# ------------------------ >8 ------------------------ # reviewdog results # ------------------------ >8 ------------------------ # reviewdog results
To avoid other linters comments such as golint. # ------------------------ >8 ------------------------ # reviewdog results
GitHub API returns position/line as end line for multiline comments. # ------------------------ >8 ------------------------ # reviewdog results
# ------------------------ >8 ------------------------ # reviewdog results
…iff context. Removed LnumDiff usage as well. GitHub API error: Line must be part of the diff and Start line must be part of the same hunk as the line. # ------------------------ >8 ------------------------ # reviewdog results