Add support to report results to Gitea review comments #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haya14busa
requested changes
Dec 2, 2023
lafriks
force-pushed
the
feat/gitea_pr_review
branch
2 times, most recently
from
4ab655f to
08c9f9f
Compare
lafriks
force-pushed
the
feat/gitea_pr_review
branch
from
08c9f9f to
837c163
Compare
lafriks
force-pushed
the
feat/gitea_pr_review
branch
from
6e97ce7 to
ace01eb
Compare
lafriks
force-pushed
the
feat/gitea_pr_review
branch
from
ace01eb to
3757936
Compare
haya14busa
requested changes
Dec 5, 2023
|
@lafriks I don't have any access to gitia. Did you test the code actually works with gitia? |
|
I'm also a maintainer of Gitea, so I did a testing on my computer with the dev version. Are there any examples with integration tests? Is it possible to start a docker based service in GitHub actions? |
|
If you want to test you can also do that on https://try.gitea.io/ but I would not use it for integration tests |
lafriks
force-pushed
the
feat/gitea_pr_review
branch
from
362535e to
7d36daf
Compare
|
For GitLab, we have an integration test. We created a synced repo and use GitLab CI. https://github.com/reviewdog/reviewdog/blob/master/.gitlab-ci.yml |
haya14busa
approved these changes
Dec 6, 2023
|
Thank you for your work！👍 |
|
I will see if I can do about implementing tests, at minimum unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1295
Should probably wait for gitea/go-sdk#638