Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --filter-mode=file in github-pr-review #1576

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Support --filter-mode=file in github-pr-review #1576

merged 2 commits into from
Oct 1, 2023

Conversation

bgpat
Copy link
Member

@bgpat bgpat commented Sep 18, 2023 •
edited
Loading

closes #1572

Support --filter-mode=file in github-pr-review by falling back to file comment when outside of diff context.

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

@shogo82148 shogo82148 merged commit 4d54cf8 into reviewdog:master Oct 1, 2023
@review-dog
Copy link
Member

Hi, @bgpat! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

@bgpat bgpat deleted the bgpat/github-file-comment branch October 1, 2023 06:54
@haya14busa haya14busa mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakib1 hakib1 hakib1 approved these changes

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --filter-mode=[file/nofilter] in github-pr-review
4 participants
@bgpat @review-dog @shogo82148 @hakib1