Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(github): detect pr_target #1014

Merged
merged 3 commits into from
Aug 4, 2021
Merged

fix(github): detect pr_target #1014

merged 3 commits into from
Aug 4, 2021

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Aug 4, 2021

this should fix #1010

I don't know why action_name is removed from the GITHUB_EVENT_PATH, but it's documented as env GITHUB_EVENT_NAME now

And sorry, I'm new here, could anyone help me with the changelog? How should I add this.

@shogo82148
Copy link
Contributor

I don't know why action_name is removed from the GITHUB_EVENT_PATH, but it's documented as env GITHUB_EVENT_NAME now

hmm, I don't know why too.
But action_name is removed from the GITHUB_EVENT_PATH actually: https://gist.github.com/shogo82148/4edb6ec701ec590b80dfc51646fe38a7

And sorry, I'm new here, could anyone help me with the changelog? How should I add this.

Oh sorry about this. I forgot to add the Unreleased section. It's done in #1016

@shogo82148 shogo82148 merged commit 98c2678 into reviewdog:master Aug 4, 2021
@review-dog
Copy link
Member

Hi, @trim21! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

shogo82148 added a commit that referenced this pull request Aug 4, 2021
@shogo82148
add a changelog for #1014
03f4d44
@shogo82148
Copy link
Contributor

I added this pull request to the CHANGELOG 03f4d44

Can you review it? #1016

@trim21 trim21 deleted the patch-1 branch August 4, 2021 20:42
@Tacha-S Tacha-S mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github-pr-review report permission error with corrent token
3 participants
@trim21 @shogo82148 @review-dog