Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unexpected failures for github-check (doghouse) flow #609

Merged
merged 5 commits into from
May 31, 2020
Merged

Conversation

haya14busa
Copy link
Member

@haya14busa haya14busa commented May 31, 2020

Fix #596
This is follow-up of #513.

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

# ------------------------ >8 ------------------------
# reviewdog results
@@ -1,3 +1,3 @@
package testdata

var X = 2
var X = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint-pr-review-subdir] reported by reviewdog 🐶
exported var X should have comment or be unexported

@@ -1,3 +1,3 @@
package testdata

var X = 2
var X = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint-pr-review-nofilter] reported by reviewdog 🐶
exported var X should have comment or be unexported

@@ -1,3 +1,3 @@
package testdata

var X = 2
var X = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint-ok] reported by reviewdog 🐶
exported var X should have comment or be unexported

@haya14busa haya14busa merged commit 0321a7d into master May 31, 2020
@haya14busa haya14busa deleted the dhcli branch May 31, 2020 14:27
@haya14busa haya14busa mentioned this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle exit_codes properly
1 participant