Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of predefined CI_API_V4_URL instead of GITLAB_API #563

Closed
nadiamoe opened this issue May 7, 2020 · 2 comments · Fixed by #565
Closed

Make use of predefined CI_API_V4_URL instead of GITLAB_API #563

nadiamoe opened this issue May 7, 2020 · 2 comments · Fixed by #565

Comments

@nadiamoe
Copy link
Contributor

nadiamoe commented May 7, 2020

Since Gitlab 11.7, a variable containing the URL to the gitlab API v4 is automatically set by gitlab: CI_API_V4_URL.

reviewdog could use this instead of GITLAB_API, perhaps as a fall-back mechanism (try GITLAB_API first, fall back to CI_API_V4_URL if the former is not set) to not break existing configurations.

I have not checked the code but the change seems pretty straightforward, so I could probably work on a PR for this if you are interested.
@haya14busa
Copy link
Member

Sounds good! Can you work on it?

@nadiamoe
Copy link
Contributor Author

nadiamoe commented May 7, 2020

I'll give it a shot :)

@nadiamoe nadiamoe mentioned this issue May 7, 2020
Merged
@haya14busa haya14busa mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: use CI_API_V4_URL env as gitlab API URL
2 participants
@nadiamoe @haya14busa