Generalize framework #65
Conversation
jsmassa
commented
Oct 25, 2021
jsmassa
commented
- removes code from default-store only applying to filestore
- rename variables
- restructure migration code to use protocols
- adding existence check for store
There was a problem hiding this comment.
I like the introduction of the distinction between store creation and store connection. Since this maps to Datahike as well it might be good to also have a high-level konserve protocol to create and connect a store. For me it looks fine, I would just like to understand why we need the underscore names.
| @@ -21,7 +21,7 @@ | |||
| ;; durable | |||
|
|
|||
|
|
|||
| (defn get-lock [{:keys [locks] :as store} key] | |||
| (defn get-lock [{:keys [locks] :as _store} key] | |||
There was a problem hiding this comment.
These underscore names are unusual in Clojure. Why do you need to introduce them? I assume you want to avoid shadowing. I find store' a bit nicer if you really need to avoid shadowing, but usually it should not be necessary in function arguments.
There was a problem hiding this comment.
There was a problem hiding this comment.
@TimoKramer thanks, I did not catch up with this newer style guid.
