Minor SPA mode updates #8464
Minor SPA mode updates #8464
Conversation
🦋 Changeset detectedLatest commit: 771ce47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if ( | ||
| !html.includes("window.__remixContext =") || | ||
| !html.includes("window.__remixRouteModules =") | ||
| ) { | ||
| throw new Error( | ||
| "SPA Mode: Did you forget to include <Scripts/> in your `root.tsx` " + | ||
| "`HydrateFallback` component? Your `index.html` file cannot hydrate " + | ||
| "into a SPA without `<Scripts />`." | ||
| ); | ||
| } |
There was a problem hiding this comment.
Detect if they forgot <Scripts> since SPA mode is useless without it
| // In SPA Mode, there's nothing to restore on initial render since we didn't | ||
| // render anything on the server | ||
| if (isSpaMode) { | ||
| return null; |
There was a problem hiding this comment.
We don't need to do initial SSR scroll restoration in SPA mode since no content was SSR'd
| @@ -38,6 +38,7 @@ export function HydrateFallback() { | |||
| <body> | |||
| <p>Loading...</p> | |||
| <Scripts /> | |||
| <LiveReload /> | |||
There was a problem hiding this comment.
Needed for HMR to wire up correctly
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
No description provided.