Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: use isbot version 4" #8414

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Revert "chore: use isbot version 4" #8414

merged 1 commit into from
Jan 2, 2024

Conversation

brophdawg11
Copy link
Contributor

Reverts #8385 (see comment

If we blindly upgrade our internal entry.server file top use isbot@4 and started installing v4 from remix dev, then we'd be fine for (1) net-new apps and (2) existing apps who have run npx remix reveal.

But it would be a breaking change for existing apps who have isbot@3 in their package.json but who have not run npx remix reveal since the internal versions used by @remix-run/dev would start assuming the isbot@4 API which uses a named export not available in isbot@3.

This reverts the original change so we can figure out the right way to solve in a subsequent PR:

  • The easiest solution is to just lock into 3.x
  • Another solution is to try to feature detect v3 vs. v4 - need to see how messy that is in entry.server

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2024

⚠️ No Changeset found

Latest commit: 4500969

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 merged commit 7c2291e into dev Jan 2, 2024
9 checks passed
@brophdawg11 brophdawg11 deleted the revert-8385-use-isbot-version-4 branch January 2, 2024 21:19
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 2, 2024
@brophdawg11 brophdawg11 mentioned this pull request Jan 2, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

🤖 Hello there,

We just published version 2.5.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed dependencies Pull requests that update a dependency file docs package:dev template:architect template:cloudflare-pages template:cloudflare-workers template:deno template:express template:fly template:remix template:remix-javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brophdawg11 @MichaelDeBoey