Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev/vite): preload Vite ESM build in CLI #8339

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix(remix-dev/vite): preload Vite ESM build in CLI #8339

merged 1 commit into from
Dec 21, 2023

Conversation

markdalgleish
Copy link
Member

Now that we've introduced Vite-specific CLI commands, we have two new entrypoints into a Vite context. We need to call our preloadViteEsm function at the top of these commands to ensure any calls to loadViteEsmSync don't fail.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: 57ba606

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 3593c35 into dev Dec 21, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/preload-vite-esm-cli branch December 21, 2023 01:09
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed package:dev vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markdalgleish