Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite): make server .client exports undefined #8220

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(vite): make server .client exports undefined #8220

merged 1 commit into from
Dec 6, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Dec 5, 2023 •
edited
Loading

This changes the stubbed-out .client export values from {} to undefined. This matches the behaviour of the old Remix compiler, making runtime checks less error prone and providing better runtime errors if you accidentally try to use a client-only module on the server.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2023

⚠️ No Changeset found

Latest commit: 0ac6d91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori merged commit 1534c78 into dev Dec 6, 2023
9 checks passed
@pcattori pcattori deleted the markdalgleish/update-dot-client-exports branch December 6, 2023 00:00
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🤖 Hello there,

We just published version 2.4.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

🤖 Hello there,

We just published version 2.4.0-pre.7 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.0-pre.9 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcattori pcattori pcattori approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdalgleish @pcattori