Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update msw example to msw@2.x version + add ESM related details #8053

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

mccuna
Copy link
Contributor

@mccuna mccuna commented Nov 18, 2023

I've updated the msw example based on the breaking changes they introduced in v2. Also, considering that Kent's epic-stack uses ESM by default I've added a few details regarding ESM modules to the msw example (might be useful for people using epic-stack as a reference).

Copy link

changeset-bot bot commented Nov 18, 2023

⚠️ No Changeset found

Latest commit: 70d638c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11 brophdawg11 merged commit 0b662a3 into remix-run:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants