Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(start/tutorial): fix filenames #7490

Merged
merged 2 commits into from
Sep 19, 2023
Merged

docs(start/tutorial): fix filenames #7490

merged 2 commits into from
Sep 19, 2023

Conversation

valbaca
Copy link
Contributor

@valbaca valbaca commented Sep 19, 2023

Some referenced app/routes/root.tsx , replacing those with app/root.tsx

If this is a simple docs change, go ahead and delete all this.

@valbaca
Update tutorial.md to use app/root.tsx consistently
4df33a4 
Some referenced app/routes/root.tsx , replacing those with app/root.tsx
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 907126e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 19, 2023

Hi @valbaca,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 19, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Update tutorial.md to use app/root.tsx consistently docs(start/tutorial): fix filenames Sep 19, 2023
@MichaelDeBoey MichaelDeBoey merged commit f7b90d4 into remix-run:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valbaca @MichaelDeBoey