Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tutorials/jokes): update to be compatible with v2_dev #7162

Merged
merged 1 commit into from
Aug 25, 2023
Merged

docs(tutorials/jokes): update to be compatible with v2_dev #7162

merged 1 commit into from
Aug 25, 2023

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

@MichaelDeBoey MichaelDeBoey added docs v2 Issues related to v2 apis labels Aug 14, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: afea99e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Aug 14, 2023
Closed
Merged
pcattori
pcattori requested changes Aug 15, 2023
View reviewed changes
docs/tutorials/jokes.md Outdated Show resolved Hide resolved
@brophdawg11 brophdawg11 removed their request for review August 15, 2023 20:36
@MichaelDeBoey MichaelDeBoey force-pushed the update-jokes-tutorial branch from df395c4 to 7d42902 Compare August 15, 2023 21:03
@MichaelDeBoey MichaelDeBoey requested a review from pcattori August 15, 2023 21:04
@MichaelDeBoey MichaelDeBoey force-pushed the update-jokes-tutorial branch 2 times, most recently from 20de45a to bd851ca Compare August 16, 2023 01:35
pcattori
pcattori requested changes Aug 16, 2023
View reviewed changes
docs/tutorials/jokes.md Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the update-jokes-tutorial branch from bd851ca to 73996ca Compare August 16, 2023 12:51
@MichaelDeBoey MichaelDeBoey requested a review from pcattori August 16, 2023 12:52
@MichaelDeBoey MichaelDeBoey force-pushed the update-jokes-tutorial branch 4 times, most recently from d52df96 to 9dfd6e6 Compare August 22, 2023 22:37
kentcdodds
kentcdodds reviewed Aug 22, 2023
View reviewed changes
docs/tutorials/jokes.md Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the update-jokes-tutorial branch from 9dfd6e6 to 3bc8b10 Compare August 22, 2023 23:17
kentcdodds
kentcdodds approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelDeBoey MichaelDeBoey force-pushed the update-jokes-tutorial branch from 3bc8b10 to ec9cda7 Compare August 23, 2023 17:49
@MichaelDeBoey MichaelDeBoey force-pushed the update-jokes-tutorial branch from ec9cda7 to afea99e Compare August 25, 2023 00:42
@MichaelDeBoey MichaelDeBoey merged commit 6b6bb39 into remix-run:main Aug 25, 2023
@MichaelDeBoey MichaelDeBoey deleted the update-jokes-tutorial branch August 25, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

@pcattori pcattori pcattori approved these changes

@ryanflorence ryanflorence Awaiting requested review from ryanflorence

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
CLA Signed docs package:dev v2 Issues related to v2 apis
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelDeBoey @pcattori @kentcdodds @brophdawg11