🦋 Changeset detected

Latest commit: b640a6b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

🤖 Hello there,

We just published version v0.0.0-nightly-382edbe-20230617 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Can confirm about 25% improvement in rebuild time (3.2s -> 2.5s) on an WIndows i7-7700 setup with the latest nightly build!

Before v1.17.0

After 0.0.0-nightly-25620b9-20230618

#6539 @lili21 can you confirm?

can confirm, rebuild time goes down from 1.9 to 1.4s。

🤖 Hello there,

We just published version 1.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

I been noticing random app crashes with v0.0.0-nightly-aa896a4-20230619 and 1.18.0-pre.0:

They don't seem to happen with 0.0.0-nightly-25620b9-20230618.

I'm not able to reproduce this error consistently enough to nail down its cause, unfortunately. Will report back if anything changes.

@xHomu can you console.log(build) right before you call broadcastDevReady? Curious what that looks like since it should have a assets.version set.

@xHomu can you console.log(build) right before you call broadcastDevReady? Curious what that looks like since it should have a assets.version set.

@pcattori This is on an CJS app, so we're using require(BUILD_DR) instead: https://github.com/manawiki/starrail/blob/main/core.server.ts

Output from adding console.log(require(BUILD_DIR)):

EDIT

Seems to be working fine?

@pcattori I'm not sure if it's entirely related, but I noticed another weird bug introduced between 0.0.0-nightly-25620b9-20230618 and 1.18.0-pre.0.

Weird .css.map error with chrome devtools on:

Seems like it's expecting a sourcemap file for .css as well?

This one is reproduceable, you should able build this locally if you still have the .env I sent from before https://github.com/manawiki/starrail/tree/remix_v1.18_pre_bug

Above error shows on Windows with devtools on, switch to 0.0.0-nightly-25620b9-20230618 the error goes away.

@xHomu if you are still encountering these issues, could you create separate GitHub issues?

🤖 Hello there,

We just published version 1.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!