Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add deduplicate-yarn workflow #6109

Merged
merged 17 commits into from
Aug 8, 2023
Merged

chore: add deduplicate-yarn workflow #6109

merged 17 commits into from
Aug 8, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Apr 19, 2023 •
edited
Loading

automation of #6108

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd9c547

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh mentioned this pull request Apr 19, 2023
Merged
MichaelDeBoey
MichaelDeBoey requested changes Apr 19, 2023
View reviewed changes
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
MichaelDeBoey
MichaelDeBoey approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😍

#6108 still needs to be merged though

.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
@mcansh
Copy link
Collaborator Author

mcansh commented Apr 20, 2023

LGTM! 😍

#6108 still needs to be merged though

i'll check it out in the morning, didnt want to just yolo approve from my phone on this one

@MichaelDeBoey MichaelDeBoey mentioned this pull request May 6, 2023
Merged
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 10, 2023
Merged
@brophdawg11 brophdawg11 added the dependencies Pull requests that update a dependency file label Jul 10, 2023
@MichaelDeBoey MichaelDeBoey changed the title ci: dedupe yarn.lock chore: add deduplicate-yarn workflow Aug 7, 2023
MichaelDeBoey
MichaelDeBoey requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this consistent with remix-run/react-router#10583 and remix-run/examples#248 & remix-run/examples#263

.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/dedupe-yarn.yml Outdated Show resolved Hide resolved
.github/workflows/format.yml Outdated Show resolved Hide resolved
.github/workflows/format.yml Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev August 7, 2023 19:14
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review August 7, 2023 19:23
@brophdawg11 brophdawg11 merged commit b2d8691 into dev Aug 8, 2023
@brophdawg11 brophdawg11 deleted the logan/dedupe-yarn branch August 8, 2023 16:50
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 8, 2023
Merged
@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@pcattori pcattori Awaiting requested review from pcattori

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
CLA Signed dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcansh @brophdawg11 @MichaelDeBoey