Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-testing): use router.routes so routes have ids #5128

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Jan 18, 2023

TODO:

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

  • Docs
  • Tests

Testing Strategy:

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: f76f243

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
remix Patch
@remix-run/testing Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh marked this pull request as ready for review January 18, 2023 17:43
@mcansh mcansh merged commit ed03d1b into dev Jan 18, 2023
@mcansh mcansh deleted the logan/testing-helpers-auto-id branch January 18, 2023 19:22
@github-actions github-actions bot added awaiting release This issue has been fixed and will be released soon and removed awaiting release This issue has been fixed and will be released soon labels Jan 18, 2023
@remix-run remix-run deleted a comment from github-actions bot Jan 19, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-45ba8d6-20230119 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

andrelandgraf pushed a commit to andrelandgraf/remix that referenced this pull request Jan 22, 2023
…#5128)

* fix(remix-testing): use router.routes so routes have ids

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* test: add some tests

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* chore: add all packages to jest projects

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* Create mighty-beans-judge.md

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants