Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(templates): use typeof check for requestIdleCallback #4999

Merged
merged 1 commit into from
Jan 4, 2023
Merged

chore(templates): use typeof check for requestIdleCallback #4999

merged 1 commit into from
Jan 4, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Jan 4, 2023 •
edited
Loading

safari doesn't have requestIdleCallback thus logging errors to the console

Unhandled Promise Rejection: ReferenceError: Can't find variable: requestIdleCallback
(anonymous function)
rejectPromise
promiseReactionJob

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2023

⚠️ No Changeset found

Latest commit: 6748b85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title chore(templates): use typeof check for requestIdleCallback chore(templates): use typeof check for requestIdleCallback Jan 4, 2023
@MichaelDeBoey MichaelDeBoey merged commit b438e52 into main Jan 4, 2023
@MichaelDeBoey MichaelDeBoey deleted the logan/typeof-requestIdleCallback branch January 4, 2023 17:04
staylor pushed a commit to staylor/remix that referenced this pull request Jan 9, 2023
@mcansh @staylor
chore(templates): use typeof check for requestIdleCallback (remix-r…
d67f07a 
…un#4999)
This was referenced Feb 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed template:architect template:cloudflare-pages template:cloudflare-workers template:deno template:express template:fly template:netlify template:remix template:vercel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcansh @MichaelDeBoey