Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templates/deno): grab @remix-run/deno types directly from node_modules/ #3689

Merged
merged 1 commit into from
Jul 9, 2022
Merged

fix(templates/deno): grab @remix-run/deno types directly from node_modules/ #3689

merged 1 commit into from
Jul 9, 2022

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jul 9, 2022

See the existing comment in .vscode/resolve_npm_imports.json

@pcattori pcattori requested a review from chaance July 9, 2022 17:16
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2022

⚠️ No Changeset found

Latest commit: e488d70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey merged commit 730b398 into main Jul 9, 2022
@MichaelDeBoey MichaelDeBoey deleted the pedro/fix-remix-deno-types-for-deno-template branch July 9, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@chaance chaance Awaiting requested review from chaance

Assignees
No one assigned
Labels
CLA Signed template:deno
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcattori @MichaelDeBoey