chore(refactor): Create magicExports in Rollup build
#3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaance
commented
Jun 22, 2022
MichaelDeBoey
requested changes
Jun 22, 2022
|
The only thing I notice on a quick diff of a dev 'use strict';
Object.defineProperty(exports, '__esModule', { value: true }); |
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
brophdawg11
approved these changes
Jun 22, 2022
…run/remix into chance/remove-magic-exports-files
MichaelDeBoey
requested changes
Jun 22, 2022
This was referenced Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all
magicExportsmodules from the source code and emits the files via Rollup instead. This eliminates any issues with TS or Node module resolution that will occur from copying the build output into adistdirectory alongside the package source.This will unblock #3540 which in turn will unblock the work needed to implement Changesets.