Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(templates/deno): update types config #3516

Merged
merged 2 commits into from
Aug 4, 2022
Merged

chore(templates/deno): update types config #3516

merged 2 commits into from
Aug 4, 2022

Conversation

jacob-ebey
Copy link
Member

Closes: #

  • Docs
  • Tests

Testing Strategy:

@MichaelDeBoey MichaelDeBoey changed the title chore: update deno template types config chore(templates/deno): update types config Jun 19, 2022
@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Jun 19, 2022 •
edited
Loading

@jacob-ebey We already have #3449, so I think it would be good to join forces on that one?

pcattori
pcattori requested changes Aug 4, 2022
View reviewed changes
templates/deno/tsconfig.json Outdated Show resolved Hide resolved
templates/deno/.vscode/settings.json Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the jacob/deno-template-config branch from 3add35b to 341a829 Compare August 4, 2022 14:55
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: c2dd639

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori merged commit c2cd0b3 into main Aug 4, 2022
@pcattori pcattori deleted the jacob/deno-template-config branch August 4, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@pcattori pcattori pcattori approved these changes

Assignees
No one assigned
Labels
CLA Signed template:deno
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacob-ebey @MichaelDeBoey @pcattori